K8SPG-1019 Apply Go 1.26 code improvements using go fix#1585
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| "github.com/percona/percona-postgresql-operator/v2/internal/controller/runtime" | ||
| "github.com/percona/percona-postgresql-operator/v2/internal/initialize" | ||
|
|
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
|
|
||
| "github.com/percona/percona-postgresql-operator/v2/internal/feature" | ||
| "github.com/percona/percona-postgresql-operator/v2/internal/initialize" | ||
|
|
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
| "github.com/percona/percona-postgresql-operator/v2/internal/config" | ||
| "github.com/percona/percona-postgresql-operator/v2/internal/feature" | ||
| "github.com/percona/percona-postgresql-operator/v2/internal/initialize" | ||
|
|
Contributor
There was a problem hiding this comment.
[goimports-reviser] reported by reviewdog 🐶
Suggested change
gkech
requested review from
egegunes,
hors,
mayankshah1607,
nmarukovich,
oksana-grishchenko and
pooknull
as code owners
|
|
||
| // Bool returns a pointer to v. | ||
| func Bool(v bool) *bool { return &v } | ||
| // |
Member
There was a problem hiding this comment.
Do we still need this package? I saw that almost all usage of initialize was replaced with new
Contributor
Author
There was a problem hiding this comment.
we still use the package for other functions here and there, better not to do anything with it under this pr
Contributor
Author
There was a problem hiding this comment.
Removed some functions from the package that are not used and fixed some unit tests that, after the go fix didn't do anything meaningful.
mayankshah1607
previously approved these changes
May 6, 2026
gkech
requested review from
eleo007,
jvpasinatto and
valmiranogueira
as code owners
hors
previously approved these changes
May 7, 2026
pooknull
previously approved these changes
May 7, 2026
egegunes
approved these changes
May 11, 2026
mayankshah1607
approved these changes
May 11, 2026
Collaborator
commit: f606450 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-1019
CHANGE DESCRIPTION
Problem:
Go 1.26 revamped go fix with 22 new analyzers that automatically modernize code to use current Go idioms. We should run these across the codebase and apply the suggested changes.
Similar PR: percona/percona-xtradb-cluster-operator#2460
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability